[ List Earliest Comments Only For Pages | Games | Rated Pages | Rated Games | Subjects of Discussion ]
Check out Janggi (Korean Chess), our featured variant for December, 2024.
Check out Janggi (Korean Chess), our featured variant for December, 2024.
I think the addition of a prince would be interesting for MakePiece in the fairy-move-model.
Well, I added the Crowned Rook and Bishop, for letters 'D' and 'H', to correspond with their usual Shogi designation Dragon(-King) and (Dragon-)Horse. To make the H available for this I moved the Champion to 'O' (for Omega Champion, just as I used X for Xiangqi Cannon).
This leaves 'F', 'I', 'J' and 'Y' still unused. I am in doubt about the Prince; I know Jean-Louis uses it a lot, but otherwise it is not a very well-known piece. So I am not sure whether I should prefer it over a normal Commoner (or perhaps include both).
As to Michel's leaving: it would be nice to push something before that, but we should be careful to not do things in a rush, so that we have regrets, and have to alter them later. For instance, now that I have made new pieces, I might want to use those in variants I made earlier (e.g. a real Phoenix in Team-Mate Chess, and the 2d icons for the generals in Chu Shogi). I am also pretty sure that there are more elegant ways to rescale pieces than keeping around a duplicat of their .js fil with an altered scale property in it.
Perhaps I should create a new branch, initially a copy of 'trial', in which I would then reorganize all commits such that those applying to the same feature become sequential, and then squash those into a single commit. And only then send Michel a pull request for it. E.g. the development of fairy-move-model now involves many commits (some still to come?), and it would be nice if it was committed as a single completed module to the master branch.